Issue 5557044: code review 5557044: goprotobuf: GetExtension now returns a specific error w...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5557044: code review 5557044: goprotobuf: GetExtension now returns a specific error w... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by dsymonds

Modified:
13 years, 10 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: GetExtension now returns a specific error when the requested extension is missing. Also tidy up property parsing a little bit.

Patch Set 1 #

Patch Set 2 : diff -r 18929c34d26b https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 18929c34d26b https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 18929c34d26b https://code.google.com/p/goprotobuf #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	proto/extensions.go	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
	M	proto/properties.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

13 years, 10 months ago (2012-01-18 01:46:33 UTC) #1

dsymonds

13 years, 10 months ago (2012-01-18 07:28:03 UTC) #3

*** Submitted as eddc77e78bda ***

goprotobuf: GetExtension now returns a specific error when the requested
extension is missing.

Also tidy up property parsing a little bit.

R=r
CC=golang-dev
http://codereview.appspot.com/5557044

Expand All Messages | Collapse All Messages