code review 5555056: os: fix Plan 9 build after more FileMode changes

os: fix Plan 9 build after more FileMode changes

This should go in after Brad's CL 5553064.

[ality, 2012-01-19 22:12:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-01-19 22:16:14]

LGTM from a style perspective.

I don't know Plan9, but seems plausibly correct.

[rsc, 2012-01-19 22:24:10]

LGTM

[rsc, 2012-01-19 22:24:24]

Will leave for Brad to submit after the other CL.

[bradfitz, 2012-01-19 22:27:18]

Actually, I renamed posixMode to syscallMode, and dropped all my changed to
the _plan9.go file in my CL.

On Thu, Jan 19, 2012 at 2:16 PM, <bradfitz@golang.org> wrote:

> LGTM from a style perspective.
>
> I don't know Plan9, but seems plausibly correct.
>
>
>
https://codereview.appspot.**com/5555056/<https://codereview.appspot.com/5555...
>

[ality, 2012-01-19 22:32:15]

Hello golang-dev@googlegroups.com, bradfitz@golang.org, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2012-01-20 00:07:03]

Ignore me if I have no clue about plan9.

I can submit this if you're still confident in it after looking at the posix
version that was just submitted.

http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go
File src/pkg/os/file_plan9.go (right):

http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go#newc...
src/pkg/os/file_plan9.go:62: if i&ModeDir != 0 {
this was removed from the posix version.  still want this?

http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go#newc...
src/pkg/os/file_plan9.go:66: o |= syscall.DMAPPEND
is this a flag or a permission?

http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go#newc...
src/pkg/os/file_plan9.go:69: o |= syscall.DMEXCL
is this a flag or a permission?

http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go#newc...
src/pkg/os/file_plan9.go:72: o |= syscall.DMTMP
is this a flag or a permission?

[ality, 2012-01-20 00:27:20]

bradfitz@golang.org once said:
> Ignore me if I have no clue about plan9.
> 
> I can submit this if you're still confident in it after looking at the
> posix version that was just submitted.
> 
> 
> http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go
> File src/pkg/os/file_plan9.go (right):
> 
>
http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go#newc...
> src/pkg/os/file_plan9.go:62: if i&ModeDir != 0 {
> this was removed from the posix version.  still want this?

Yeah.  On Plan 9 the way you create directories
is with create(..., DMDIR|mode).  This should stay.

>
http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go#newc...
> src/pkg/os/file_plan9.go:66: o |= syscall.DMAPPEND
> is this a flag or a permission?
> 
>
http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go#newc...
> src/pkg/os/file_plan9.go:69: o |= syscall.DMEXCL
> is this a flag or a permission?
> 
>
http://codereview.appspot.com/5555056/diff/1003/src/pkg/os/file_plan9.go#newc...
> src/pkg/os/file_plan9.go:72: o |= syscall.DMTMP
> is this a flag or a permission?

These are all permissions.  From the shell, you can
do "chmod +alt" to make an append-only, temporary,
exclusive-use file. :-)

> http://codereview.appspot.com/5555056/

[rsc, 2012-01-20 18:24:02]

I disagree about DMDIR.
If you want to create a directory using package os
on Plan 9 you should use Mkdir, same as on the
other systems.  Otherwise code that runs on Plan 9
may not run elsewhere.  Package os is supposed to
be consistent across platforms.

Russ

[ality, 2012-01-21 03:16:20]

Russ Cox <rsc@golang.org> once said:
> I disagree about DMDIR.
> If you want to create a directory using package os
> on Plan 9 you should use Mkdir, same as on the
> other systems.  Otherwise code that runs on Plan 9
> may not run elsewhere.  Package os is supposed to
> be consistent across platforms.

Good point.  I've removed DMDIR.  PTAL

  Anthony

[rsc, 2012-01-21 03:25:31]

LGTM

[ality, 2012-01-21 04:01:37]

*** Submitted as f8ee219794ac ***

os: fix Plan 9 build after more FileMode changes

This should go in after Brad's CL 5553064.

R=bradfitz, rsc
CC=golang-dev
http://codereview.appspot.com/5555056