Issue 5555054: Fix warning in libtess; turn on NDEBUG in Release builds

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5555054: Fix warning in libtess; turn on NDEBUG in Release builds (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by Stephen White

Modified:
12 years, 2 months ago

Reviewers:
bsalomon, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Fix a warning in libtess in Release builds. This only showed up in Chrome builds, since skia's gyp files were only defining NDEBUG on Windows. Fixed by defining it for the other platforms too. BUG=456

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
		gyp/common_conditions.gypi	View		3 chunks	+5 lines, -2 lines	0 comments	Download
		third_party/glu/gluos.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Stephen White

12 years, 2 months ago (2012-02-07 18:31:20 UTC) #3

On 2012/01/19 19:49:40, bsalomon wrote:
> On 2012/01/19 19:33:03, Stephen White wrote:
> 
> LGTM

Was landed as http://code.google.com/p/skia/source/detail?r=3076.  Closing.

Expand All Messages | Collapse All Messages