Added optional ability to disable consecutive slash suppression in paths in boto

[marccohen, 2012-01-18 23:10:47]

http://codereview.appspot.com/5555050/diff/1/boto/connection.py
File boto/connection.py (right):

http://codereview.appspot.com/5555050/diff/1/boto/connection.py#newcode505
boto/connection.py:505: # The default behavior is to suppress consecutive
slashes for reasons
If the default behavior is to suppress consecutive slashes, it seems confusing
that the default value of suppress_consec_slashes is False.

OK, I see you fixed this in patch set 2

http://codereview.appspot.com/5555050/diff/1/boto/s3/key.py
File boto/s3/key.py (right):

http://codereview.appspot.com/5555050/diff/1/boto/s3/key.py#newcode469
boto/s3/key.py:469: 
Not seeing comments about the suppress_consec_slashes param added to this
method.

[Mike Schwartz, 2012-01-18 23:19:48]

Thanks - PTAL

http://codereview.appspot.com/5555050/diff/1/boto/connection.py
File boto/connection.py (right):

http://codereview.appspot.com/5555050/diff/1/boto/connection.py#newcode505
boto/connection.py:505: # The default behavior is to suppress consecutive
slashes for reasons
On 2012/01/18 23:10:47, marccohen wrote:
> If the default behavior is to suppress consecutive slashes, it seems confusing
> that the default value of suppress_consec_slashes is False.
> 
> OK, I see you fixed this in patch set 2

Right

http://codereview.appspot.com/5555050/diff/1/boto/s3/key.py
File boto/s3/key.py (right):

http://codereview.appspot.com/5555050/diff/1/boto/s3/key.py#newcode469
boto/s3/key.py:469: 
On 2012/01/18 23:10:47, marccohen wrote:
> Not seeing comments about the suppress_consec_slashes param added to this
> method.

Done.

[marccohen, 2012-01-18 23:23:03]

LGTM

[marccohen, 2012-01-19 01:57:17]

http://codereview.appspot.com/5555050/diff/4006/boto/storage_uri.py
File boto/storage_uri.py (right):

http://codereview.appspot.com/5555050/diff/4006/boto/storage_uri.py#newcode94
boto/storage_uri.py:94: self.suppress_consec_slashes)
Unnecessary parens which don't aid readability around
self.suppress_consec_slashes?

http://codereview.appspot.com/5555050/diff/4006/boto/storage_uri.py#newcode207
boto/storage_uri.py:207: :param suppress_consec_slashes: If provided, controls
whether
s/:param/@param/ ?

[Mike Schwartz, 2012-01-19 02:07:04]

Thanks, PTAL

http://codereview.appspot.com/5555050/diff/4006/boto/storage_uri.py
File boto/storage_uri.py (right):

http://codereview.appspot.com/5555050/diff/4006/boto/storage_uri.py#newcode94
boto/storage_uri.py:94: self.suppress_consec_slashes)
On 2012/01/19 01:57:17, marccohen wrote:
> Unnecessary parens which don't aid readability around
> self.suppress_consec_slashes?

They're required for the line wrap (unless you use backslash at line end, which
is considered less pythonic)

http://codereview.appspot.com/5555050/diff/4006/boto/storage_uri.py#newcode207
boto/storage_uri.py:207: :param suppress_consec_slashes: If provided, controls
whether
On 2012/01/19 01:57:17, marccohen wrote:
> s/:param/@param/ ?

Done.

[marccohen, 2012-01-19 02:35:53]

LGTM