code review 5553066: text/template/parse: use human error prints

text/template/parse: use human error prints
The previous version of all the node.String methods printed the parse
tree and was useful for developing the parse tree code. Now that that's done,
we might as well print the nodes using the standard template syntax.
It's much easier to read and makes error reporting look more natural.

Helps issue 2644.

[r, 2012-01-19 20:33:39]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2012-01-19 20:35:40]

LGTM

http://codereview.appspot.com/5553066/diff/1/src/pkg/text/template/parse/node.go
File src/pkg/text/template/parse/node.go (right):

http://codereview.appspot.com/5553066/diff/1/src/pkg/text/template/parse/node...
src/pkg/text/template/parse/node.go:450: return fmt.Sprintf("{{%s %s}} %s
{{else}} %s {{end}}", name, b.Pipe, b.List, b.ElseList)
Should the spaces be dropped?

[niemeyer, 2012-01-19 20:45:19]

LGTM

http://codereview.appspot.com/5553066/diff/1/src/pkg/text/template/parse/node.go
File src/pkg/text/template/parse/node.go (right):

http://codereview.appspot.com/5553066/diff/1/src/pkg/text/template/parse/node...
src/pkg/text/template/parse/node.go:114: s += " "
s/" "/", "/

http://codereview.appspot.com/5553066/diff/1/src/pkg/text/template/parse/node...
src/pkg/text/template/parse/node.go:143: return fmt.Sprintf("{{%s}}", a.Pipe)
Would it make sense to take the delimiters in use into account?

[niemeyer, 2012-01-19 20:48:16]

http://codereview.appspot.com/5553066/diff/1/src/pkg/text/template/parse/node.go
File src/pkg/text/template/parse/node.go (right):

http://codereview.appspot.com/5553066/diff/1/src/pkg/text/template/parse/node...
src/pkg/text/template/parse/node.go:143: return fmt.Sprintf("{{%s}}", a.Pipe)
On 2012/01/19 20:45:19, niemeyer wrote:
> Would it make sense to take the delimiters in use into account?

Sorry, nevermind.. this won't have the proper context for that.

[r, 2012-01-19 21:51:41]

*** Submitted as 647acba14a3e ***

text/template/parse: use human error prints
The previous version of all the node.String methods printed the parse
tree and was useful for developing the parse tree code. Now that that's done,
we might as well print the nodes using the standard template syntax.
It's much easier to read and makes error reporting look more natural.

Helps issue 2644.

R=rsc, n13m3y3r
CC=golang-dev
http://codereview.appspot.com/5553066