Issue 5549043: code review 5549043: os/exec: trivial allocation removal in LookPath

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5549043: code review 5549043: os/exec: trivial allocation removal in LookPath (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by niemeyer

Modified:
13 years, 6 months ago

Reviewers:

CC:
golang-dev, bsiegert, r

Visibility:
Public.

Description

os/exec: trivial allocation removal in LookPath

Patch Set 2 : code review 5549043: os/exec: trivial allocation removal #

Patch Set 3 : code review 5549043: os/exec: trivial allocation removal in LookPath #

Patch Set 4 : diff -r 0c2d98252018 https://go.googlecode.com/hg/ #

Total comments: 3

Patch Set 5 : diff -r 0061447a5dc8 https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/pkg/os/exec/lp_unix.go	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2012-01-17 13:08:15 UTC) #1

bsiegert

http://codereview.appspot.com/5549043/diff/2002/src/pkg/os/exec/lp_unix.go File src/pkg/os/exec/lp_unix.go (right): http://codereview.appspot.com/5549043/diff/2002/src/pkg/os/exec/lp_unix.go#newcode50 src/pkg/os/exec/lp_unix.go:50: path := dir + "/" + file Wouldn't it ...

13 years, 6 months ago (2012-01-17 13:16:41 UTC) #2

niemeyer

13 years, 6 months ago (2012-01-17 13:55:27 UTC) #3

LGTM http://codereview.appspot.com/5549043/diff/2002/src/pkg/os/exec/lp_unix.go File src/pkg/os/exec/lp_unix.go (right): http://codereview.appspot.com/5549043/diff/2002/src/pkg/os/exec/lp_unix.go#newcode50 src/pkg/os/exec/lp_unix.go:50: path := dir + "/" + file On ...

13 years, 6 months ago (2012-01-17 15:52:37 UTC) #4

niemeyer

13 years, 6 months ago (2012-01-19 22:17:53 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=b6a9e156ac24 ***

os/exec: trivial allocation removal in LookPath

R=golang-dev, bsiegert, r
CC=golang-dev
http://codereview.appspot.com/5549043

Expand All Messages | Collapse All Messages