Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(145)

Issue 5545048: code review 5545048: src: make use of runtime.GOOS, GOARCH instead of syscal... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by mikio
Modified:
13 years, 4 months ago
Reviewers:
CC:
rsc, r, golang-dev
Visibility:
Public.

Description

src: make use of runtime.GOOS, GOARCH instead of syscall.OS, ARCH

Patch Set 1 : diff -r 70e914beb409 https://go.googlecode.com/hg/ #

Patch Set 2 : diff -r 70e914beb409 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 52099988ec3a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 52099988ec3a https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r e6e421d710d7 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -83 lines) Patch
M src/buildscript_darwin_386.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_darwin_amd64.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_freebsd_386.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_freebsd_amd64.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_linux_386.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_linux_amd64.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_linux_arm.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_netbsd_386.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_netbsd_amd64.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_openbsd_386.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_openbsd_amd64.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_plan9_386.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_windows_386.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/buildscript_windows_amd64.sh View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/debug/gosym/pclntab_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/net/file_test.go View 3 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/net/server_test.go View 4 chunks +3 lines, -4 lines 0 comments Download
M src/pkg/os/os_test.go View 15 chunks +15 lines, -15 lines 0 comments Download
M src/pkg/os/os_unix_test.go View 2 chunks +2 lines, -1 line 0 comments Download
M src/pkg/os/path_test.go View 3 chunks +2 lines, -3 lines 0 comments Download
M src/pkg/syscall/Makefile View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/pkg/syscall/exec_bsd.go View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/pkg/syscall/exec_unix.go View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
R src/pkg/syscall/syscall_386.go View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
R src/pkg/syscall/syscall_amd64.go View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
R src/pkg/syscall/syscall_arm.go View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M src/pkg/syscall/syscall_bsd.go View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_darwin.go View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_freebsd.go View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_linux.go View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_netbsd.go View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_openbsd.go View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_plan9.go View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/pkg/syscall/syscall_unix.go View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7
mikio
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2012-01-13 12:53:24 UTC) #1
rsc
Should we delete theGoos and theGoarch too?
13 years, 4 months ago (2012-01-13 17:23:38 UTC) #2
r
please s/instaed/instead/ in CL description otherwise LGTM but wait for rsc
13 years, 4 months ago (2012-01-13 17:37:33 UTC) #3
mikio
On Sat, Jan 14, 2012 at 2:23 AM, Russ Cox <rsc@golang.org> wrote: > Should we ...
13 years, 4 months ago (2012-01-13 21:16:19 UTC) #4
mikio
Hello rsc@golang.org, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 4 months ago (2012-01-13 21:16:49 UTC) #5
rsc
LGTM Thanks very much.
13 years, 4 months ago (2012-01-13 21:39:38 UTC) #6
mikio
13 years, 4 months ago (2012-01-13 21:40:58 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=f5142a5cac19 ***

src: make use of runtime.GOOS, GOARCH instead of syscall.OS, ARCH

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/5545048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b