code review 5545047: gc: fieldnames in structliterals in exported inlines sh...

gc: fieldnames in structliterals in exported inlines should not be qualified if they're embedded builtin types.

Trust me.
Fixes issue 2687.

[lvd, 2012-01-14 13:16:34]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2012-01-16 23:23:06]

http://codereview.appspot.com/5545047/diff/1002/src/cmd/gc/fmt.c
File src/cmd/gc/fmt.c (right):

http://codereview.appspot.com/5545047/diff/1002/src/cmd/gc/fmt.c#newcode1152
src/cmd/gc/fmt.c:1152: // another special case: if n->left is an embedded field
of builtin type,
I think this would be significantly simpler as

if(embedded) {
   t = fieldtype
   if(t->sym == S)
      t = t->type;
   fmtprint(f, "%T: %N", t, l->n->right);
} else 
   fmtprint(f, "%hhS: %N", l->n->left->sym, l->n->right);

[lvd, 2012-01-17 09:28:01]

On 2012/01/17 09:24:24, lvd wrote:

hm, i think i said 'not significantly simpler but done anyway' but rietveld ate
my comments.  so all done and passing.

[lvd, 2012-01-17 19:37:52]

Hello rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-01-18 16:47:55]

LGTM

[lvd, 2012-01-18 16:51:33]

*** Submitted as http://code.google.com/p/go/source/detail?r=3c060add43fb ***

gc: fieldnames in structliterals in exported inlines should not be qualified if
they're embedded builtin types.

Trust me.
Fixes issue 2687.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5545047