Issue 5543065: code review 5543065: net: fix unintentional error variable shadowing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5543065: code review 5543065: net: fix unintentional error variable shadowing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by mikio

Modified:
13 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

net: fix unintentional error variable shadowing

Patch Set 1 #

Patch Set 2 : diff -r 0640cfa9d9cf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0640cfa9d9cf https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 0640cfa9d9cf https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/pkg/net/sock.go	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2012-01-17 01:51:02 UTC) #1

rsc

LGTM I am not sure how feasible it is to review old CLs for shadowing, ...

13 years, 6 months ago (2012-01-17 01:55:43 UTC) #2

mikio

On Tue, Jan 17, 2012 at 10:55 AM, <rsc@golang.org> wrote: > I am not sure ...

13 years, 6 months ago (2012-01-17 01:58:23 UTC) #3

mikio

13 years, 6 months ago (2012-01-17 01:59:45 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=a9b973007c20 ***

net: fix unintentional error variable shadowing

R=rsc
CC=golang-dev
http://codereview.appspot.com/5543065

Expand All Messages | Collapse All Messages