code review 5543060: exp/inotify: fix data race in linux tests

exp/inotify: fix data race in linux tests
Fixes issue 2708.

[dvyukov, 2012-01-16 06:35:23]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
mpimenov@google.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-01-16 06:39:04]

LGTM
 On Jan 15, 2012 10:35 PM, <dvyukov@google.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com,
> mpimenov@google.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> exp/inotify: fix data race in linux tests
> Fixes issue 2708.
>
> Please review this at
http://codereview.appspot.com/**5543060/<http://codereview.appspot.com/5543060/>
>
> Affected files:
>  M src/pkg/exp/inotify/inotify_**linux_test.go
>
>
> Index: src/pkg/exp/inotify/inotify_**linux_test.go
> ==============================**==============================**=======
> --- a/src/pkg/exp/inotify/inotify_**linux_test.go
> +++ b/src/pkg/exp/inotify/inotify_**linux_test.go
> @@ -83,14 +83,15 @@
>        watcher, _ := NewWatcher()
>        watcher.Close()
>
> -       done := false
> +       done := make(chan bool)
>        go func() {
>                watcher.Close()
> -               done = true
> +               done <- true
>        }()
>
> -       time.Sleep(50 * time.Millisecond)
> -       if !done {
> +       select {
> +       case <-done:
> +       case <-time.After(50 * time.Millisecond):
>                t.Fatal("double Close() test failed: second Close() call
> didn't return")
>        }
>
>
>
>

[dvyukov, 2012-01-16 07:12:26]

*** Submitted as http://code.google.com/p/go/source/detail?r=113f887bd82b ***

exp/inotify: fix data race in linux tests
Fixes issue 2708.

R=golang-dev, bradfitz
CC=golang-dev, mpimenov
http://codereview.appspot.com/5543060