Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 5543054: code review 5543054: go/doc: rewrote and completed test framework (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by gri
Modified:
13 years, 6 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go/doc: rewrote and completed test framework Packages to test are kept in ./testdata together with the corresponding golden (packagename.out) file. To update the golden files, run: go test -update

Patch Set 1 #

Patch Set 2 : diff -r 3f5cf6adf1c2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3f5cf6adf1c2 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3f5cf6adf1c2 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r c44d47cfe0a2 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r c44d47cfe0a2 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r c44d47cfe0a2 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r f891d14d88e2 https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 866e1330783f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1143 lines, -110 lines) Patch
M src/pkg/go/doc/doc_test.go View 1 2 3 4 1 chunk +83 lines, -110 lines 0 comments Download
A src/pkg/go/doc/testdata/a.out View 1 2 3 4 5 1 chunk +13 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/a0.go View 1 1 chunk +8 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/a1.go View 1 1 chunk +8 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/b.go View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/b.out View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/benchmark.go View 1 2 3 4 1 chunk +293 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/example.go View 1 2 3 4 1 chunk +81 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/template.txt View 1 2 3 4 5 1 chunk +65 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/testing.go View 1 2 3 4 1 chunk +404 lines, -0 lines 0 comments Download
A src/pkg/go/doc/testdata/testing.out View 1 2 3 4 5 1 chunk +144 lines, -0 lines 0 comments Download

Messages

Total messages: 4
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 6 months ago (2012-01-13 21:30:11 UTC) #1
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
13 years, 6 months ago (2012-01-17 23:22:01 UTC) #2
rsc
LGTM Nice.
13 years, 6 months ago (2012-01-18 19:17:37 UTC) #3
gri
13 years, 6 months ago (2012-01-18 22:11:49 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=2fc359321899 ***

go/doc: rewrote and completed test framework

Packages to test are kept in ./testdata together
with the corresponding golden (packagename.out)
file.

To update the golden files, run: go test -update

R=rsc
CC=golang-dev
http://codereview.appspot.com/5543054
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b