Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 5542049: code review 5542049: exp/terminal: add SetPrompt and handle large pastes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by agl1
Modified:
13 years, 6 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

exp/terminal: add SetPrompt and handle large pastes. (This was missing in the last change because I uploaded it from the wrong machine.) Large pastes previously misbehaved because the code tried reading from the terminal before checking whether an line was already buffered. Large pastes can cause multiples lines to be read at once from the terminal.

Patch Set 1 #

Patch Set 2 : diff -r 4c300745d3c3 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 4c300745d3c3 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 06cebc7f3a29 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 06cebc7f3a29 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -28 lines) Patch
M src/pkg/exp/terminal/terminal.go View 1 2 3 4 2 chunks +34 lines, -28 lines 0 comments Download

Messages

Total messages: 2
agl1
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 6 months ago (2012-01-14 15:58:11 UTC) #1
agl1
13 years, 6 months ago (2012-01-14 15:59:26 UTC) #2
*** Submitted as http://code.google.com/p/go/source/detail?r=f36c0825e0cd ***

exp/terminal: add SetPrompt and handle large pastes.

(This was missing in the last change because I uploaded it from the
wrong machine.)

Large pastes previously misbehaved because the code tried reading from
the terminal before checking whether an line was already buffered.
Large pastes can cause multiples lines to be read at once from the
terminal.

R=bradfitz
CC=golang-dev
http://codereview.appspot.com/5542049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b