Allow <a> and <area> links to open in the same page rather than a new one

Removes the requirement for all links to open in a new page and updates
corresponding tests.

@4769

[felix8a, 2012-01-17 08:44:32]

http://codereview.appspot.com/5541069/diff/1/tests/com/google/caja/plugin/tem...
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right):

http://codereview.appspot.com/5541069/diff/1/tests/com/google/caja/plugin/tem...
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:157:
htmlFragment(fromString("<a href='foo' target='_self'>hello</a>")),
it seems a bit obnoxious that target=foo gets rewritten to target=_self, rather
than target=_blank.  how about add
  "safeValue": "_blank"
to html4-attributes.json?

[Jasvir, 2012-01-19 18:07:16]

http://codereview.appspot.com/5541069/diff/1/tests/com/google/caja/plugin/tem...
File tests/com/google/caja/plugin/templates/TemplateCompilerTest.java (right):

http://codereview.appspot.com/5541069/diff/1/tests/com/google/caja/plugin/tem...
tests/com/google/caja/plugin/templates/TemplateCompilerTest.java:157:
htmlFragment(fromString("<a href='foo' target='_self'>hello</a>")),
Done.

Also modified HtmlSchema to so safeValue is defaultValue if no value is provided
and the defaultValue is safe.

On 2012/01/17 08:44:32, felix8a wrote:
> it seems a bit obnoxious that target=foo gets rewritten to target=_self,
rather
> than target=_blank.  how about add
>   "safeValue": "_blank"
> to html4-attributes.json?

[felix8a, 2012-01-19 19:18:14]

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/lang/html...
File src/com/google/caja/lang/html/html4-attributes.json (right):

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/lang/html...
src/com/google/caja/lang/html/html4-attributes.json:30: "We allow _blank, _self
but _parent, _top or arbitary named ",
"but" should be "but not"

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/plugin/do...
File src/com/google/caja/plugin/domado.js (left):

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/plugin/do...
src/com/google/caja/plugin/domado.js:1383: elementPolicies.a =
elementPolicies.area = function (attribs) {
the client-side sanitizer doesn't handle any of the attribute value
whitelisting, so deleting this element policy means the client-side sanitizer
will always delete target attributes, which I guess is ok for now, but maybe
should be fixed sometime.

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/plugin/te...
File src/com/google/caja/plugin/templates/TemplateCompiler.java (right):

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/plugin/te...
src/com/google/caja/plugin/templates/TemplateCompiler.java:219:
a.getValueCriterion().accept(a.getDefaultValue())) {
getDefaultValue might be null here, and accept might throw NPE

[Jasvir, 2012-01-19 21:58:56]

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/lang/html...
File src/com/google/caja/lang/html/html4-attributes.json (right):

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/lang/html...
src/com/google/caja/lang/html/html4-attributes.json:30: "We allow _blank, _self
but _parent, _top or arbitary named ",
On 2012/01/19 19:18:15, felix8a wrote:
> "but" should be "but not"

Done.

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/plugin/do...
File src/com/google/caja/plugin/domado.js (left):

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/plugin/do...
src/com/google/caja/plugin/domado.js:1383: elementPolicies.a =
elementPolicies.area = function (attribs) {
Fixed in rewriteAttributes.

On 2012/01/19 19:18:15, felix8a wrote:
> the client-side sanitizer doesn't handle any of the attribute value
> whitelisting, so deleting this element policy means the client-side sanitizer
> will always delete target attributes, which I guess is ok for now, but maybe
> should be fixed sometime.

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/plugin/te...
File src/com/google/caja/plugin/templates/TemplateCompiler.java (right):

http://codereview.appspot.com/5541069/diff/5002/src/com/google/caja/plugin/te...
src/com/google/caja/plugin/templates/TemplateCompiler.java:219:
a.getValueCriterion().accept(a.getDefaultValue())) {
On 2012/01/19 19:18:15, felix8a wrote:
> getDefaultValue might be null here, and accept might throw NPE

Done.

[felix8a, 2012-01-19 22:22:55]

lgtm

[Jasvir, 2012-01-24 01:47:48]

Snapshot.  Added missing case in TemplateSanitizer and added an end-to-end test.
Removed unneeded cropping in formatSelf which is only used for debugging.

[felix8a, 2012-01-24 18:47:02]

On 2012/01/24 01:47:48, Jasvir wrote:
> Snapshot.  Added missing case in TemplateSanitizer and added an end-to-end
test.
> Removed unneeded cropping in formatSelf which is only used for debugging.

lgtm