Issue 5541063: code review 5541063: net/http: rename ServeFile to ServeOSFile, add new ServeFile

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 5541063: code review 5541063: net/http: rename ServeFile to ServeOSFile, add new ServeFile (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 months ago by adg

Modified:
3 months, 2 weeks ago

Reviewers:
rsc, r2

CC:
golang-dev_googlegroups.com

Visibility:
Public.

Description

net/http: rename ServeFile to ServeOSFile, add new ServeFile

This new function takes an http.File and simply serves its contents,
bypassing the redirect behavior (that can still be used through
FileServer).

ServeOSFile is now a mere helper that opens the named file from the
local file system and invokes ServeFile.

Users of the original ServeFile will need to switch to using FileServer
(if they need the redirect behavior) or just use ServeOSFile.

Fixes issue 2039.

Patch Set 1 #

Patch Set 2 : diff -r f690897afe60 https://go.googlecode.com/hg #

Created: 4 months ago

Download raw patch set

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
M	src/pkg/net/http/fs.go	View	1	4 chunks	+81 lines, -65 lines	0 comments	Download
M	src/pkg/net/http/fs_test.go	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/net/http/serve_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

adg

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

4 months ago #1

adg

Hello golang-dev@googlegroups.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

4 months ago #3

*** Abandoned ***

Expand All Messages | Collapse All Messages