code review 5541063: net/http: rename ServeFile to ServeOSFile, add new ServeFile

net/http: rename ServeFile to ServeOSFile, add new ServeFile

This new function takes an http.File and simply serves its contents,
bypassing the redirect behavior (that can still be used through
FileServer).

ServeOSFile is now a mere helper that opens the named file from the
local file system and invokes ServeFile.

Users of the original ServeFile will need to switch to using FileServer
(if they need the redirect behavior) or just use ServeOSFile.

Fixes issue 2039.

[adg, 2012-01-15 22:21:32]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg

[rsc, 2012-01-16 20:13:01]

Better name please.

[adg, 2012-01-16 23:11:36]

Hello golang-dev@googlegroups.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-01-16 23:15:18]

Sorry, but I can't stomach ServeOSFile.

[r2, 2012-01-17 00:06:39]

I'm reminded of the first BSTJ Unix issue, from the era when AT&T's lawyers were
adamant that we use a ™ on Unix, and/or the word system, plus upper case, and
honor everyone else's trademarks in a similar way.  One of the articles was a
reprint of the CACM article, in which the phrase

   PDP-11 Unix file system

was edited by the lawyers into

   PDP-11™ computer system UNIX™ system file system

Dennis fought back.

-rob

[adg, 2012-02-02 06:32:21]

*** Abandoned ***