Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(248)

Issue 5541050: Add a node prefix to snippets, preventing duplicate node errors (issue 2221). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Julien Rioux
Modified:
12 years, 3 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add a node prefix to snippets, preventing duplicate node errors (issue 2221).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M Documentation/snippets.tely View 1 chunk +7 lines, -2 lines 0 comments Download
M Documentation/snippets/ancient-notation-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/chords-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/contexts-and-engravers-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/editorial-annotations-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/expressive-marks-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/fretted-strings-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/keyboards-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/midi-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/paper-and-layout-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/percussion-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/pitches-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/repeats-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/rhythms-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/simultaneous-notes-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/spacing-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/staff-notation-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/template-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/text-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/titles-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/tweaks-and-overrides-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/unfretted-strings-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/vocal-music-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/winds-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/world-music-intro.itely View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/build/extract_texi_filenames.py View 4 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 3
Julien Rioux
Open for review.
12 years, 3 months ago (2012-01-13 06:13:17 UTC) #1
Graham Percival
Looks Absolutely Fantastic To Me. Please push directly to staging once Patchy has finished testing ...
12 years, 3 months ago (2012-01-13 07:45:06 UTC) #2
Reinhold
12 years, 3 months ago (2012-01-13 11:52:45 UTC) #3
I had tried this very approach a while ago, but there were some problems.
Unfortunately, I can't remember which problems I encountered.

One issue might be that all links to one particular snippet will be broken with
that patch.

If you don't encounter any problems with broken links etc., then I'm fine with
the patch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b