Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(671)

Issue 5541045: code review 5541045: go/doc: move CommentText to ast.CommentGroup's Text method (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 11 months ago by rsc
Modified:
13 years, 11 months ago
Reviewers:
CC:
gri, golang-dev
Visibility:
Public.

Description

go/doc: move CommentText to ast.CommentGroup's Text method Now only godoc imports go/doc.

Patch Set 1 #

Patch Set 2 : diff -r 29382b5af719 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 29382b5af719 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8f82e0f84bfe https://code.google.com/p/go/ #

Patch Set 5 : diff -r f5c795dba2ad https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+837 lines, -1263 lines) Patch
M src/buildscript_darwin_386.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_darwin_amd64.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_freebsd_386.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_freebsd_amd64.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_linux_386.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_linux_amd64.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_linux_arm.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_netbsd_386.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_netbsd_amd64.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_openbsd_386.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_openbsd_amd64.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
src/buildscript_plan9_386.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_windows_386.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
M src/buildscript_windows_amd64.sh View 1 2 3 4 chunks +54 lines, -84 lines 0 comments Download
src/cmd/cgo/ast.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/cmd/go/pkg.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/cmd/go/test.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/cmd/godoc/dirtrees.go View 1 2 chunks +1 line, -2 lines 0 comments Download
src/cmd/gotest/gotest.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/go/ast/ast.go View 1 2 chunks +69 lines, -0 lines 0 comments Download
M src/pkg/go/build/dir.go View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/pkg/go/doc/comment.go View 1 2 chunks +0 lines, -69 lines 0 comments Download
src/pkg/go/doc/example.go View 1 1 chunk +1 line, -1 line 0 comments Download
src/pkg/go/doc/reader.go View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5
rsc
Hello gri (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years, 11 months ago (2012-01-12 19:28:41 UTC) #1
gri
LGTM Do the build scripts have to be updated?
13 years, 11 months ago (2012-01-12 19:32:10 UTC) #2
rsc
On Thu, Jan 12, 2012 at 11:32, <gri@golang.org> wrote: > LGTM > > Do the ...
13 years, 11 months ago (2012-01-12 19:32:48 UTC) #3
gri
LGTM
13 years, 11 months ago (2012-01-12 19:33:48 UTC) #4
rsc
13 years, 11 months ago (2012-01-12 19:34:03 UTC) #5
*** Submitted as ddeadd4b2995 ***

go/doc: move CommentText to ast.CommentGroup's Text method

Now only godoc imports go/doc.

R=gri
CC=golang-dev
http://codereview.appspot.com/5541045
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b