changes.tely: mention Flag changes, remove duplicate "does"

changes.tely: mention Flag changes, remove duplicate "does"

[Pavel Roskin, 2012-01-16 00:46:31]

The changelog doesn't mention the issue I have to deal with all the time, namely
splitting Flag from Stem.  If not that change, I would be able to use Lilypond
2.14.2 and the development version without convert-ly on the same sources.  It
should definitely be mentioned.  An example is added to show how the flag can be
colored now.

Also, there was a duplicate "does" in the section about grace notes.

[Carl, 2012-01-16 05:45:10]

Looks good to me, but I wonder about the location.

Thanks,

Carl

http://codereview.appspot.com/5540058/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

http://codereview.appspot.com/5540058/diff/1/Documentation/changes.tely#newco...
Documentation/changes.tely:210: @item
I'm a bit concerned about adding this down here.  Somebody who is only tracking
the top of CHANGES wil miss this.

I assume (but haven't checked) that this is in the right place relative to the
other changes.

I'd like to get some other opinions about it -- should it go here or at the top?

[Carl, 2012-01-16 05:45:11]

Looks good to me, but I wonder about the location.

Thanks,

Carl

[pkx166h, 2012-01-16 13:02:51]

Well I'd say at the top. Many of the changes I have added in the last year have
not necessarily gone in the correct 'order'; when someone mentioned that
something needed to be added, it went in on the top of the pile.

People do follow the changes, so the assumption is that it is current, if we
have never mentioned this 'change' before, it makes sense to add it to the top
instead of hiding it below.

I think while things are still in dev, until we release a stable the 'order'
doesn't matter that much.

[Pavel Roskin, 2012-01-16 15:34:17]

OK, my mistake, I didn't read the comments on top of changes.tely.  The fixed
patch is attached as patch set 2.

[janek, 2012-01-18 05:46:47]

lgtm

[Graham Percival, 2012-01-18 13:28:02]

LGTM

[Neil Puttock, 2012-01-18 15:13:47]

http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely
File Documentation/changes.tely (right):

http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely#ne...
Documentation/changes.tely:67: \override Flag #'color = #red g8
Please put the note on a new line.

[Pavel Roskin, 2012-01-18 22:28:50]

On 2012/01/18 15:13:47, Neil Puttock wrote:
> http://codereview.appspot.com/5540058/diff/3003/Documentation/changes.tely
Done

[pkx166h, 2012-01-26 21:20:53]

Pavel, I pushed for you.

author	Pavel Roskin <proski@gnu.org>	
 Thu, 26 Jan 2012 21:17:13 +0000 (21:17 +0000)

committer James Lowe <pkx166h@gmail.com>	
Thu, 26 Jan 2012 21:19:06 +0000 (21:19 +0000)

commit	224246365f67fb44799fee4eb00e5debea5a35ec

Can you close this issue here?

James