code review 5540047: cmd/go: handle cgo pkg-config pragmas

cmd/go: handle cgo pkg-config pragmas

Fixes issue 2681.

[rsc, 2012-01-12 22:38:13]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-01-12 22:51:02]

LGTM

http://codereview.appspot.com/5540047/diff/2001/src/cmd/go/build.go
File src/cmd/go/build.go (right):

http://codereview.appspot.com/5540047/diff/2001/src/cmd/go/build.go#newcode808
src/cmd/go/build.go:808: func relPaths(dir, out string) string {
was this unrelated cleanup?  you don't use this function elsewhere in this CL.

[rsc, 2012-01-12 22:51:29]

On Thu, Jan 12, 2012 at 14:51,  <bradfitz@golang.org> wrote:
> src/cmd/go/build.go:808: func relPaths(dir, out string) string {
> was this unrelated cleanup?  you don't use this function elsewhere in
> this CL.

yes; see other CLs

[rsc, 2012-01-12 22:53:29]

On Thu, Jan 12, 2012 at 14:51, Russ Cox <rsc@golang.org> wrote:
> On Thu, Jan 12, 2012 at 14:51,  <bradfitz@golang.org> wrote:
>> src/cmd/go/build.go:808: func relPaths(dir, out string) string {
>> was this unrelated cleanup?  you don't use this function elsewhere in
>> this CL.
>
> yes; see other CLs

you already reviewed the other one, but if
you are bored 5540048 and 5543046 are
available

[rsc, 2012-01-12 23:04:40]

*** Submitted as 137470d33cc9 ***

cmd/go: handle cgo pkg-config pragmas

Fixes issue 2681.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5540047