code review 5540046: go/ast: remove unnecessary result value from ast.Fprint...

go/ast: remove unnecessary result value from ast.Fprint/Print

These functions are mostly of interest for debugging; the
number of bytes written is uninteresting.

[gri, 2012-01-12 20:54:17]

Hello r@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-01-12 20:57:22]

http://codereview.appspot.com/5540046/diff/4001/src/pkg/go/ast/print.go
File src/pkg/go/ast/print.go (right):

http://codereview.appspot.com/5540046/diff/4001/src/pkg/go/ast/print.go#newco...
src/pkg/go/ast/print.go:39: func Fprint(w io.Writer, fset *token.FileSet, x
interface{}, f FieldFilter) (err error) {
I would remove the err result parameter name now.

[r, 2012-01-12 21:34:07]

http://codereview.appspot.com/5540046/diff/4001/src/pkg/go/ast/print.go
File src/pkg/go/ast/print.go (right):

http://codereview.appspot.com/5540046/diff/4001/src/pkg/go/ast/print.go#newco...
src/pkg/go/ast/print.go:37: // are printed; all others are filtered from the
output.
worth saying this has a different signature from fmt.Fprint?

http://codereview.appspot.com/5540046/diff/4001/src/pkg/go/ast/print.go#newco...
src/pkg/go/ast/print.go:39: func Fprint(w io.Writer, fset *token.FileSet, x
interface{}, f FieldFilter) (err error) {
On 2012/01/12 20:57:22, bradfitz wrote:
> I would remove the err result parameter name now.

agreed

[gri, 2012-01-12 21:58:02]

PTAL.

http://codereview.appspot.com/5540046/diff/4001/src/pkg/go/ast/print.go
File src/pkg/go/ast/print.go (right):

http://codereview.appspot.com/5540046/diff/4001/src/pkg/go/ast/print.go#newco...
src/pkg/go/ast/print.go:37: // are printed; all others are filtered from the
output.
On 2012/01/12 21:34:08, r wrote:
> worth saying this has a different signature from fmt.Fprint?

I don't think it's necessary. For one, the parameters are all different anyway,
and we don't generally comment on a single error result.

http://codereview.appspot.com/5540046/diff/4001/src/pkg/go/ast/print.go#newco...
src/pkg/go/ast/print.go:39: func Fprint(w io.Writer, fset *token.FileSet, x
interface{}, f FieldFilter) (err error) {
On 2012/01/12 20:57:22, bradfitz wrote:
> I would remove the err result parameter name now.

Not possible because that value is changed by defer.

http://codereview.appspot.com/5540046/diff/4001/src/pkg/go/ast/print.go#newco...
src/pkg/go/ast/print.go:39: func Fprint(w io.Writer, fset *token.FileSet, x
interface{}, f FieldFilter) (err error) {
On 2012/01/12 21:34:08, r wrote:
> On 2012/01/12 20:57:22, bradfitz wrote:
> > I would remove the err result parameter name now.
> 
> agreed

See above.

[r, 2012-01-12 23:12:58]

LGTM

[gri, 2012-01-13 00:04:21]

*** Submitted as http://code.google.com/p/go/source/detail?r=c58ddc8f0210 ***

go/ast: remove unnecessary result value from ast.Fprint/Print

These functions are mostly of interest for debugging; the
number of bytes written is uninteresting.

R=r, bradfitz
CC=golang-dev
http://codereview.appspot.com/5540046