code review 5540043: go/build: allow colon in #cgo flags

go/build: allow colon in #cgo flags

This makes it possible to say -I c:/foo on Windows.

Fixes issue 2683 comment #3.

[rsc, 2012-01-12 18:43:32]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-01-12 18:48:31]

LGTM
On Jan 12, 2012 10:43 AM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> go/build: allow colon in #cgo flags
>
> This makes it possible to say -I c:/foo on Windows.
>
> Fixes issue 2683 comment #3.
>
> Please review this at
http://codereview.appspot.com/**5540043/<http://codereview.appspot.com/5540043/>
>
> Affected files:
>  M src/pkg/go/build/dir.go
>
>
> Index: src/pkg/go/build/dir.go
> ==============================**==============================**=======
> --- a/src/pkg/go/build/dir.go
> +++ b/src/pkg/go/build/dir.go
> @@ -476,7 +476,7 @@
>        return nil
>  }
>
> -var safeBytes = []byte("+-.,/0123456789=**ABCDEFGHIJKLMNOPQRSTUVWXYZ_**
> abcdefghijklmnopqrstuvwxyz")
> +var safeBytes = []byte("+-.,/0123456789=**ABCDEFGHIJKLMNOPQRSTUVWXYZ_**
> abcdefghijklmnopqrstuvwxyz:")
>
>  func safeName(s string) bool {
>        if s == "" {
>
>
>

[rsc, 2012-01-12 19:05:54]

*** Submitted as b7d84fb0b635 ***

go/build: allow colon in #cgo flags

This makes it possible to say -I c:/foo on Windows.

Fixes issue 2683 comment #3.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5540043