Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 5539079: code review 5539079: testing: document examples (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by r
Modified:
13 years, 6 months ago
Reviewers:
r2
CC:
golang-dev, rsc, adg
Visibility:
Public.

Description

testing: document examples The package documentation did not mention them. They were described only in godoc for gotest, and that's going away.

Patch Set 1 #

Total comments: 1

Patch Set 2 : diff -r b8e06e57073b https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M src/pkg/testing/testing.go View 1 3 chunks +29 lines, -1 line 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
13 years, 6 months ago (2012-01-17 19:44:10 UTC) #1
rsc
LGTM also in 'go help testfunc' i believe.
13 years, 6 months ago (2012-01-17 22:04:24 UTC) #2
adg
This is also documented in "go help testfunc". http://codereview.appspot.com/5539079/diff/1/src/pkg/testing/testing.go File src/pkg/testing/testing.go (right): http://codereview.appspot.com/5539079/diff/1/src/pkg/testing/testing.go#newcode46 src/pkg/testing/testing.go:46: // ...
13 years, 6 months ago (2012-01-17 22:06:36 UTC) #3
r
*** Submitted as e4bcc2a6f294 *** testing: document examples The package documentation did not mention them. ...
13 years, 6 months ago (2012-01-17 22:20:31 UTC) #4
r2
13 years, 6 months ago (2012-01-17 22:21:10 UTC) #5
On Jan 17, 2012, at 2:04 PM, Russ Cox wrote:

> LGTM
> 
> also in 'go help testfunc' i believe.

which refers to the documentation for package testing for more information

-rob


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b