Issue 5539061: code review 5539061: cmd/gofmt: fix simplify.go by running gofmt on cmd/gofmt

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5539061: code review 5539061: cmd/gofmt: fix simplify.go by running gofmt on cmd/gofmt (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by dupoxy

Modified:
13 years, 6 months ago

Reviewers:
gri

CC:
golang-dev

Visibility:
Public.

Description

cmd/gofmt: fix simplify.go by running gofmt on cmd/gofmt

Patch Set 1 #

Patch Set 2 : diff -r 42af4dd5b2e1 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 42af4dd5b2e1 https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/gofmt/simplify.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dupoxy

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2012-01-14 02:02:10 UTC) #1

gri

*** Submitted as http://code.google.com/p/go/source/detail?r=91dc5ab5094f *** cmd/gofmt: fix simplify.go by running gofmt on cmd/gofmt R=golang-dev CC=golang-dev ...

13 years, 6 months ago (2012-01-14 02:05:51 UTC) #2

gri

13 years, 6 months ago (2012-01-14 02:05:56 UTC) #3

LGTM

On Fri, Jan 13, 2012 at 6:02 PM,  <duperray.olivier@gmail.com> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> cmd/gofmt: fix simplify.go by running gofmt on cmd/gofmt
>
> Please review this at http://codereview.appspot.com/5539061/
>
> Affected files:
>  M src/cmd/gofmt/simplify.go
>
>
> Index: src/cmd/gofmt/simplify.go
> ===================================================================
> --- a/src/cmd/gofmt/simplify.go
> +++ b/src/cmd/gofmt/simplify.go
> @@ -50,8 +50,8 @@
>                                        if addr, ok := x.(*ast.UnaryExpr); ok
> && addr.Op == token.AND {
>                                                if inner, ok :=
> addr.X.(*ast.CompositeLit); ok {
>                                                        if match(nil,
> reflect.ValueOf(ptr.X), reflect.ValueOf(inner.Type)) {
> -                                                               inner.Type =
> nil  // drop T
> -                                                               *px = inner
> // drop &
> +                                                               inner.Type =
> nil // drop T
> +                                                               *px = inner
>      // drop &
>                                                        }
>                                                }
>                                        }
>
>

Expand All Messages | Collapse All Messages