Issue 5536058: code review 5536058: test: change several tests to not print

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5536058: code review 5536058: test: change several tests to not print (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by iant

Modified:
13 years, 9 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

test: change several tests to not print This will make these tests more meaningful for gccgo, which runs tests in parallel and has no equivalent to golden.out. Remove ken/simpprint.go since it duplicates helloworld.go.

Patch Set 1 #

Patch Set 2 : diff -r 8c0e39009d5e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8c0e39009d5e https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2fc359321899 https://go.googlecode.com/hg/ #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -113 lines)			Patch
M	test/fixedbugs/bug027.go	View	1 2	3 chunks	+20 lines, -3 lines	0 comments	Download
M	test/fixedbugs/bug070.go	View	1 2	2 chunks	+15 lines, -4 lines	0 comments	Download
M	test/golden.out	View	1	5 chunks	+0 lines, -57 lines	0 comments	Download
M	test/ken/cplx4.go	View	1	1 chunk	+21 lines, -7 lines	0 comments	Download
M	test/ken/label.go	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	test/ken/rob1.go	View	1 2	4 chunks	+11 lines, -7 lines	0 comments	Download
M	test/ken/rob2.go	View	1 2	2 chunks	+19 lines, -13 lines	0 comments	Download
R	test/ken/simpprint.go	View	1	1 chunk	+0 lines, -13 lines	0 comments	Download
M	test/ken/simpswitch.go	View	1 2	1 chunk	+8 lines, -5 lines	0 comments	Download
M	test/peano.go	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
M	test/turing.go	View	1	3 chunks	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 9 months ago (2012-01-18 21:50:31 UTC) #1

iant

13 years, 9 months ago (2012-01-18 22:31:34 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=3170ab1185ee ***

test: change several tests to not print

This will make these tests more meaningful for gccgo, which
runs tests in parallel and has no equivalent to golden.out.

Remove ken/simpprint.go since it duplicates helloworld.go.

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5536058

Expand All Messages | Collapse All Messages