Issue 5536045: code review 5536045: exp/sql: rename NullableString to NullString and allow ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5536045: code review 5536045: exp/sql: rename NullableString to NullString and allow ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by bradfitz

Modified:
13 years, 6 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

exp/sql: rename NullableString to NullString and allow its use as a parameter Prep for Issue 2699

Patch Set 1 #

Patch Set 2 : diff -r c44d47cfe0a2 https://go.googlecode.com/hg #

Patch Set 3 : diff -r c44d47cfe0a2 https://go.googlecode.com/hg #

Patch Set 4 : diff -r a23c27c34ba9 https://go.googlecode.com/hg #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -12 lines)			Patch
M	src/pkg/exp/sql/convert_test.go	View	1	3 chunks	+35 lines, -2 lines	0 comments	Download
M	src/pkg/exp/sql/driver/types.go	View	1	4 chunks	+47 lines, -1 line	0 comments	Download
M	src/pkg/exp/sql/fakedb_test.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/pkg/exp/sql/sql.go	View	1	3 chunks	+37 lines, -8 lines	0 comments	Download
M	src/pkg/exp/sql/sql_test.go	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg

13 years, 6 months ago (2012-01-18 00:08:08 UTC) #1

rsc

LGTM SubsetValuer seems fine as a name. I'm not too worried about the driver package.

13 years, 6 months ago (2012-01-19 17:20:41 UTC) #2

bradfitz

13 years, 6 months ago (2012-01-19 17:27:48 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=ca2fc0db9471 ***

exp/sql: rename NullableString to NullString and allow its use as a parameter

Prep for Issue 2699

R=rsc
CC=golang-dev
http://codereview.appspot.com/5536045

Expand All Messages | Collapse All Messages