code review 5535055: go/parser: Remove unused Parse* functions. Simplified P...

go/parser: Remove unused Parse* functions. Simplified ParseExpr signature.

Only ParseFile, ParseDir, and ParseExpr are used in the tree.
If partial parsing of code is required, it is fairly simple
to wrap the relevant piece of code into a dummy package for
parsing (see parser.ParseExpr).

Also: minor cleanups.

[gri, 2012-01-12 03:15:22]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[gri, 2012-01-12 03:23:14]

PS: I can write a gofix module for ParseExpr but I am not sure it's worth it.
- gri

On Wed, Jan 11, 2012 at 7:15 PM,  <gri@golang.org> wrote:
> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> go/parser: Remove unused Parse* functions. Simplified ParseExpr
> signature.
>
> Only ParseFile, ParseDir, and ParseExpr are used in the tree.
> If partial parsing of code is required, it is fairly simple
> to wrap the relevant piece of code into a dummy package for
> parsing (see parser.ParseExpr).
>
> Please review this at http://codereview.appspot.com/5535055/
>
> Affected files:
>  M src/cmd/cgo/gcc.go
>  M src/cmd/gofix/fix.go
>  M src/cmd/gofmt/rewrite.go
>  M src/pkg/go/parser/interface.go
>  M src/pkg/go/parser/parser.go
>  M src/pkg/go/parser/parser_test.go
>
>

[gri, 2012-01-12 19:41:57]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-01-12 23:17:58]

LGTM

[gri, 2012-01-13 00:04:37]

*** Submitted as http://code.google.com/p/go/source/detail?r=aab4d2ed7ed8 ***

go/parser: Remove unused Parse* functions. Simplified ParseExpr signature.

Only ParseFile, ParseDir, and ParseExpr are used in the tree.
If partial parsing of code is required, it is fairly simple
to wrap the relevant piece of code into a dummy package for
parsing (see parser.ParseExpr).

Also: minor cleanups.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5535055