Issue 5535044: code review 5535044: ld: parse but do not implement -X flag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5535044: code review 5535044: ld: parse but do not implement -X flag (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by rsc

Modified:
13 years, 6 months ago

Reviewers:

CC:
iant, golang-dev

Visibility:
Public.

Description

ld: parse but do not implement -X flag This will let programs invoking ld prepare for it. See issue 2676.

Patch Set 1 #

Patch Set 2 : diff -r 620dc567f123 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 620dc567f123 https://code.google.com/p/go/ #

Patch Set 4 : diff -r f58f842c9d3b https://code.google.com/p/go/ #

Patch Set 5 : diff -r f58f842c9d3b https://code.google.com/p/go/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
M	src/cmd/5l/obj.c	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/6l/obj.c	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/cmd/8l/obj.c	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello iant (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 6 months ago (2012-01-10 19:46:42 UTC) #1

rsc

Hello iant@golang.org (cc: golang-dev@googlegroups.com), Please take another look.

13 years, 6 months ago (2012-01-12 18:18:18 UTC) #2

rsc

13 years, 6 months ago (2012-01-12 18:23:26 UTC) #4

*** Submitted as 1024e354f98b ***

ld: parse but do not implement -X flag

This will let programs invoking ld prepare for it.
See issue 2676.

R=iant
CC=golang-dev
http://codereview.appspot.com/5535044

Expand All Messages | Collapse All Messages