It looks like you started making implicit a 3-valued field but didn't actually end up ...
12 years, 3 months ago
(2012-02-03 17:40:24 UTC)
#2
It looks like you started making implicit a 3-valued field
but didn't actually end up needing all 3 values.
Revert to the old true/false, drop the enum?
forgot to edit go.y, it uses the 3rd one On Fri, Feb 3, 2012 at ...
12 years, 3 months ago
(2012-02-03 17:43:57 UTC)
#3
forgot to edit go.y, it uses the 3rd one
On Fri, Feb 3, 2012 at 18:40, Russ Cox <rsc@golang.org> wrote:
> It looks like you started making implicit a 3-valued field
> but didn't actually end up needing all 3 values.
> Revert to the old true/false, drop the enum?
On Fri, Feb 3, 2012 at 18:43, Luuk van Dijk <lvd@google.com> wrote: > forgot to ...
12 years, 3 months ago
(2012-02-03 17:46:24 UTC)
#4
On Fri, Feb 3, 2012 at 18:43, Luuk van Dijk <lvd@google.com> wrote:
> forgot to edit go.y, it uses the 3rd one
and that was really the whole crux: the ->implicit set in go.y on OIND
means something different than all the other ones. this was really
the simplest fix, i tried reorganizing the representation of
OPTRLIT/OSTRUCTLIT but that just becomes way messier.
>
> On Fri, Feb 3, 2012 at 18:40, Russ Cox <rsc@golang.org> wrote:
>> It looks like you started making implicit a 3-valued field
>> but didn't actually end up needing all 3 values.
>> Revert to the old true/false, drop the enum?
Issue 5534077: code review 5534077: gc: don't print implicit type on struct literal in export
(Closed)
Created 12 years, 3 months ago by lvd
Modified 12 years, 3 months ago
Reviewers:
Base URL:
Comments: 0