Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1064)

Issue 5534077: code review 5534077: gc: don't print implicit type on struct literal in export (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by lvd
Modified:
12 years, 3 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

gc: don't print implicit type on struct literal in export As pointed out in the discussion around 2678.

Patch Set 1 #

Patch Set 2 : diff -r cf2fb43dedaa https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r d54721805232 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 05ce1def5def https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 7c35ab6ef473 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -9 lines) Patch
M src/cmd/gc/fmt.c View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download
M src/cmd/gc/go.h View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M src/cmd/gc/go.y View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/gc/typecheck.c View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
M src/cmd/gc/y.tab.c View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M test/fixedbugs/bug392.dir/one.go View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M test/fixedbugs/bug392.dir/two.go View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6
lvd
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 3 months ago (2012-02-01 13:17:37 UTC) #1
rsc
It looks like you started making implicit a 3-valued field but didn't actually end up ...
12 years, 3 months ago (2012-02-03 17:40:24 UTC) #2
lvd
forgot to edit go.y, it uses the 3rd one On Fri, Feb 3, 2012 at ...
12 years, 3 months ago (2012-02-03 17:43:57 UTC) #3
lvd
On Fri, Feb 3, 2012 at 18:43, Luuk van Dijk <lvd@google.com> wrote: > forgot to ...
12 years, 3 months ago (2012-02-03 17:46:24 UTC) #4
rsc
LGTM there is an = 2 in go.y that should be = ImplPtr
12 years, 3 months ago (2012-02-03 17:55:48 UTC) #5
lvd
12 years, 3 months ago (2012-02-06 11:20:03 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=886ac920d2b9 ***

gc: don't print implicit type on struct literal in export

As pointed out in the discussion around 2678.

R=rsc
CC=golang-dev
http://codereview.appspot.com/5534077
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b