Issue 5534067: Chroma Matte Node

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5534067: Chroma Matte Node (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by dfelinto

Modified:
12 years, 4 months ago

Reviewers:
jbkkavt, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/branches/tile/blender

Visibility:
Public.

Description

edit: node re-reviewed by me and it seems fine, I never used it though -- committed

Patch Set 1 #

Patch Set 2 : fix in COM_ChromaMatteNode, was connecting the input of the YCC ops into the operator #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+269 lines, -0 lines)			Patch
source/blender/compositor/CMakeLists.txt	View		2 chunks	+4 lines, -0 lines	0 comments	Download
source/blender/compositor/intern/COM_Converter.cpp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
source/blender/compositor/nodes/COM_ChromaMatteNode.h	View		1 chunk	+38 lines, -0 lines	0 comments	Download
source/blender/compositor/nodes/COM_ChromaMatteNode.cpp	View	1	1 chunk	+70 lines, -0 lines	0 comments	Download
source/blender/compositor/operations/COM_ChromaMatteOperation.h	View		1 chunk	+52 lines, -0 lines	0 comments	Download
source/blender/compositor/operations/COM_ChromaMatteOperation.cpp	View	1	1 chunk	+101 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dfelinto

fix in COM_ChromaMatteNode, was connecting the input of the YCC ops into the operator

12 years, 4 months ago (2012-01-11 05:45:10 UTC) #2

jbkkavt

12 years, 4 months ago (2012-01-11 18:02:00 UTC) #3

On 2012/01/11 05:45:10, dfelinto wrote:
> fix in COM_ChromaMatteNode, was connecting the input of the YCC ops into the
> operator

Seems all fine, just need to check what to do with the unused settings in the
operation.

Jeroen
 - At Mind -

Expand All Messages | Collapse All Messages