Issue 5533066: code review 5533066: cmd/go: kill test.out after 1 minute

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5533066: code review 5533066: cmd/go: kill test.out after 1 minute (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by rsc

Modified:
13 years, 6 months ago

Reviewers:

CC:
golang-dev, dsymonds, adg

Visibility:
Public.

Description

cmd/go: kill test.out after 1 minute Will have to do better but this is enough to stop the builders from hanging, I hope.

Patch Set 2 : diff -r 090bb83020c8 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r d6e8a242ab2c https://code.google.com/p/go/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
	M	src/cmd/go/test.go	View	1 2	1 chunk	+23 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

13 years, 6 months ago (2012-01-11 04:46:56 UTC) #1

adg

https://codereview.appspot.com/5533066/diff/1002/src/cmd/go/test.go File src/cmd/go/test.go (right): https://codereview.appspot.com/5533066/diff/1002/src/cmd/go/test.go#newcode473 src/cmd/go/test.go:473: tick := time.NewTicker(deadline) NewTimer

13 years, 6 months ago (2012-01-11 04:56:02 UTC) #3

rsc

13 years, 6 months ago (2012-01-11 05:02:01 UTC) #4

*** Submitted as d5d8367a4775 ***

cmd/go: kill test.out after 1 minute

Will have to do better but this is enough to
stop the builders from hanging, I hope.

R=golang-dev, dsymonds, adg
CC=golang-dev
http://codereview.appspot.com/5533066

Expand All Messages | Collapse All Messages