Issue 5533058: code review 5533058: runtime: regenerate defs_darwin_{386,amd64}.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5533058: code review 5533058: runtime: regenerate defs_darwin_{386,amd64}.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by dave

Modified:
13 years, 7 months ago

Reviewers:

CC:
golang-dev, dsymonds, minux1

Visibility:
Public.

Description

runtime: regenerate defs_darwin_{386,amd64}.h Regenerated under Lion 10.7.2 amd64. Also tested on Snow Leopart 10.6.8 386.

Patch Set 1 #

Patch Set 2 : diff -r 7677bf602bf2 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7677bf602bf2 https://go.googlecode.com/hg/ #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -18 lines)			Patch
M	src/pkg/runtime/defs_darwin.go	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/pkg/runtime/defs_darwin_386.h	View	1	5 chunks	+7 lines, -6 lines	0 comments	Download
M	src/pkg/runtime/defs_darwin_amd64.h	View	1	8 chunks	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 7 months ago (2012-01-10 09:33:36 UTC) #1

dave_cheney.net

Regenerating under Lion MACH_SEND_CANCEL is not longer defined, and there is a change to ExceptionState32, ...

13 years, 7 months ago (2012-01-10 09:35:35 UTC) #2

dsymonds

On Tue, Jan 10, 2012 at 8:35 PM, <dave@cheney.net> wrote: > If anyone can test ...

13 years, 7 months ago (2012-01-10 10:57:04 UTC) #3

dave_cheney.net

Thanks David. I was concerned about the changes to the exceptions structs, but the older ...

13 years, 7 months ago (2012-01-10 11:59:09 UTC) #4

minux1

On Tue, Jan 10, 2012 at 5:35 PM, <dave@cheney.net> wrote: > Regenerating under Lion MACH_SEND_CANCEL ...

13 years, 7 months ago (2012-01-10 16:49:10 UTC) #5

rsc

13 years, 7 months ago (2012-01-10 17:48:14 UTC) #6

*** Submitted as 620dc567f123 ***

runtime: regenerate defs_darwin_{386,amd64}.h

Regenerated under Lion 10.7.2 amd64.
Also tested on Snow Leopart 10.6.8 386.

R=golang-dev, dsymonds, minux.ma
CC=golang-dev
http://codereview.appspot.com/5533058

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages