Issue 5532066: code review 5532066: go: rely on exit code to tell if test passed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5532066: code review 5532066: go: rely on exit code to tell if test passed (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by rsc

Modified:
13 years, 6 months ago

Reviewers:
adg, dsymonds

CC:
golang-dev

Visibility:
Public.

Description

go: rely on exit code to tell if test passed

Patch Set 1 #

Patch Set 2 : diff -r f7d0e6a40f06 https://code.google.com/p/go/ #

Patch Set 3 : diff -r f7d0e6a40f06 https://code.google.com/p/go/ #

Patch Set 4 : diff -r f7d0e6a40f06 https://code.google.com/p/go/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	src/cmd/go/test.go	View	1	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello adg (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 6 months ago (2012-01-11 04:09:57 UTC) #1

rsc

*** Submitted as 4c05941b1824 *** go: rely on exit code to tell if test passed ...

13 years, 6 months ago (2012-01-11 04:13:03 UTC) #3

adg

LGTM, I guess, but I think it's reasonable to check for the presence of \nPASS\n ...

13 years, 6 months ago (2012-01-11 04:13:40 UTC) #4

rsc

13 years, 6 months ago (2012-01-11 04:15:03 UTC) #5

On Tue, Jan 10, 2012 at 20:13,  <adg@golang.org> wrote:
> LGTM, I guess, but I think it's reasonable to check for the presence of
> \nPASS\n in the output. It might catch something bad once in a blue
> moon.

i thought so too; didn't work out.

Expand All Messages | Collapse All Messages