Issue 5532062: Separate Combine YCbCr nodes + fix for YUV

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5532062: Separate Combine YCbCr nodes + fix for YUV (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by dfelinto

Modified:
12 years, 4 months ago

Reviewers:
bf-codereview

CC:
j.bakker

Base URL:
https://svn.blender.org/svnroot/bf-blender/branches/tile/blender

Visibility:
Public.

Description

YUV was missing in COM_Converter.cpp Sep/Comb YCC could even inherit each other (given the setMode function is the same). But I think it's fine to duplicate that. Thoughts? Also, I'm not using m_privateprops C++ like naming. As we are not doing this in the other nodes. UPDATE: committed on rev. 43269

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+73 lines, -26 lines)			Patch
source/blender/blenloader/intern/readfile.c	View	1 chunk	+17 lines, -1 line	0 comments	Download
source/blender/makesdna/DNA_actuator_types.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
source/blender/makesrna/intern/rna_actuator.c	View	2 chunks	+3 lines, -1 line	0 comments	Download
source/gameengine/Converter/KX_ConvertActuators.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
source/gameengine/Ketsji/KX_CameraActuator.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
source/gameengine/Ketsji/KX_CameraActuator.cpp	View	4 chunks	+45 lines, -18 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages