Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(590)

Issue 5531058: code review 5531058: gc: enable inlining by default (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by rsc
Modified:
13 years, 4 months ago
Reviewers:
CC:
lvd, r, golang-dev
Visibility:
Public.

Description

gc: enable inlining by default

Patch Set 1 #

Patch Set 2 : diff -r d99e4c71ffc8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r d99e4c71ffc8 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 930b0346cdc5 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/cmd/gc/lex.c View 1 1 chunk +7 lines, -0 lines 0 comments Download
M test/escape2.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
rsc
Hello lvd, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
13 years, 4 months ago (2012-01-10 04:48:49 UTC) #1
r
LGTM http://codereview.appspot.com/5531058/diff/3/src/cmd/gc/lex.c File src/cmd/gc/lex.c (right): http://codereview.appspot.com/5531058/diff/3/src/cmd/gc/lex.c#newcode243 src/cmd/gc/lex.c:243: debug['l'] = 1 - debug['l']; nice
13 years, 4 months ago (2012-01-10 04:50:14 UTC) #2
lvd
can you wait a sec submitting this till we figured out how -m should behave? ...
13 years, 4 months ago (2012-01-10 09:10:04 UTC) #3
rsc
On Tue, Jan 10, 2012 at 01:10, Luuk van Dijk <lvd@google.com> wrote: > can you ...
13 years, 4 months ago (2012-01-10 16:55:04 UTC) #4
rsc
13 years, 4 months ago (2012-01-11 04:08:56 UTC) #5
*** Submitted as f7d0e6a40f06 ***

gc: enable inlining by default

R=lvd, r
CC=golang-dev
http://codereview.appspot.com/5531058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b