Issue 5530082: code review 5530082: strconv: fix round up corner case

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5530082: code review 5530082: strconv: fix round up corner case (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by rsc

Modified:
13 years, 6 months ago

Reviewers:

CC:
remyoudompheng, golang-dev

Visibility:
Public.

Description

strconv: fix round up corner case Comment described the correct condition but the code did not implement it. Fixes issue 2625.

Patch Set 1 #

Patch Set 2 : diff -r 9e6c84edb95e https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9e6c84edb95e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8f82e0f84bfe https://code.google.com/p/go/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	src/pkg/strconv/ftoa.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/pkg/strconv/ftoa_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello remyoudompheng (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

13 years, 6 months ago (2012-01-12 02:44:56 UTC) #1

rsc

13 years, 6 months ago (2012-01-12 19:32:29 UTC) #3

*** Submitted as f5c795dba2ad ***

strconv: fix round up corner case

Comment described the correct condition
but the code did not implement it.

Fixes issue 2625.

R=remyoudompheng
CC=golang-dev
http://codereview.appspot.com/5530082

Expand All Messages | Collapse All Messages