Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1130)

Issue 5530081: Finished off the GLSL compiler's support for parsing shaders using OES_EGL_image_external. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by apatrick1
Modified:
12 years, 3 months ago
Reviewers:
dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Finished off the GLSL compiler's support for parsing shaders using OES_EGL_image_external. The GLSL to HLSL translator work is not done yet so the extension is disabled in Shader.cpp. Committed: https://code.google.com/p/angleproject/source/detail?r=946

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M include/GLSLANG/ShaderLang.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M samples/translator/translator.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/common/version.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/OutputHLSL.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/OutputHLSL.cpp View 1 5 chunks +11 lines, -5 lines 0 comments Download
M src/compiler/VariableInfo.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/Shader.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
apatrick1
Hi Daniel, I'm taking a shot at implementing OES_EGL_image_external. This part is just to complete ...
12 years, 4 months ago (2012-01-11 19:58:48 UTC) #1
dgkoch
12 years, 4 months ago (2012-01-16 14:48:11 UTC) #2
LGTM

http://codereview.appspot.com/5530081/diff/1/src/compiler/OutputHLSL.cpp
File src/compiler/OutputHLSL.cpp (right):

http://codereview.appspot.com/5530081/diff/1/src/compiler/OutputHLSL.cpp#newc...
src/compiler/OutputHLSL.cpp:2023: return "sampler2D";
On 2012/01/11 19:58:48, apatrick1 wrote:
> samplerExternalOES will map to HLSL's sampler2D.

Unless we have to split it into multiple samplers :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b