Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1139)

Issue 5530080: Cucumber: World Scaling R/W + VideoTexture Constants (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by dfelinto
Modified:
12 years, 4 months ago
Reviewers:
ideasman42, bf-codereview
CC:
Kupoman
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

cucumber merge: world scaling + video texture constants revisions: 38166,38167,38177,38179,38180,38187,38242 #38242 by kupoman Adding the constants SOURCE_ERROR, SOURCE_EMPTY, SOURCE_READY, SOURCE_PLAYING, SOURCE_STOPPED to the video texture module. Updates to the documentation will follow after a merge with trunk #38187 by kupoman Updates to the documentation to reflect that worldScale is now writable, and added localTransform and worldTransform to KX_GameObject. #38180 by kupoman The Transform attribute of KX_GameObject was based on world space data. I converted that one to worldTransform, and added a localTransform for local space transform information. #38179 by kupoman Fixed the transform attribute of KX_GameObject's set method to properly deal with negative scaling. #38177 by kupoman Updated the transform property on KX_GameObject so that it is now read/write, and added the corresponding set method. Also simplified the get method by calling GetOpenGLMatrix instead of making the matrix myself. #38167 by kupoman Adding a read only transform attribute to KX_GameObject that returns a 4x4 matrix representing the object's transformations. #38166 by kupoman Adding a worldScale attribute to KX_GameObject. This attribute scales the object independently of its parent's scale. edit: comitted

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -2 lines) Patch
doc/python_api/rst/bge.types.rst View 2 chunks +13 lines, -1 line 0 comments Download
source/gameengine/Ketsji/KX_GameObject.h View 2 chunks +6 lines, -0 lines 0 comments Download
source/gameengine/Ketsji/KX_GameObject.cpp View 4 chunks +142 lines, -1 line 4 comments Download
source/gameengine/VideoTexture/blendVideoTex.cpp View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dfelinto
12 years, 4 months ago (2012-01-11 19:37:02 UTC) #1
ideasman42
+1, to commit once BLI math functions are used (should make this code a lot ...
12 years, 4 months ago (2012-01-16 08:29:35 UTC) #2
dfelinto
small note. Also it's important to remember that the rst changes are missing here (for ...
12 years, 4 months ago (2012-01-16 08:35:25 UTC) #3
ideasman42
12 years, 4 months ago (2012-01-16 09:10:27 UTC) #4
http://codereview.appspot.com/5530080/diff/1/source/gameengine/Ketsji/KX_Game...
File source/gameengine/Ketsji/KX_GameObject.cpp (right):

http://codereview.appspot.com/5530080/diff/1/source/gameengine/Ketsji/KX_Game...
source/gameengine/Ketsji/KX_GameObject.cpp:2203: MT_Matrix4x4 transform;
agree this could be moved into a new method:
self->NodeSetLocalMatrix

... which can use BLI_math too.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b