Issue 5530079: Color Matte Node

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5530079: Color Matte Node (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by dfelinto

Modified:
12 years, 4 months ago

Reviewers:
jbkkavt, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/branches/tile/blender

Visibility:
Public.

Patch Set 1 #

Total comments: 5

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+248 lines, -0 lines)			Patch
source/blender/compositor/CMakeLists.txt	View	2 chunks	+4 lines, -0 lines	0 comments	Download
source/blender/compositor/intern/COM_Converter.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
source/blender/compositor/nodes/COM_ColorMatteNode.h	View	1 chunk	+38 lines, -0 lines	0 comments	Download
source/blender/compositor/nodes/COM_ColorMatteNode.cpp	View	1 chunk	+67 lines, -0 lines	2 comments	Download
source/blender/compositor/operations/COM_ColorMatteOperation.h	View	1 chunk	+52 lines, -0 lines	0 comments	Download
source/blender/compositor/operations/COM_ColorMatteOperation.cpp	View	1 chunk	+83 lines, -0 lines	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

jbkkavt

Hi Dalai, some small remarks. The rest is ok! http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/nodes/COM_ColorMatteNode.cpp File source/blender/compositor/nodes/COM_ColorMatteNode.cpp (right): http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/nodes/COM_ColorMatteNode.cpp#newcode45 source/blender/compositor/nodes/COM_ColorMatteNode.cpp:45: ...

12 years, 4 months ago (2012-01-12 14:16:37 UTC) #2

dfelinto

12 years, 4 months ago (2012-01-12 18:54:37 UTC) #3

fixed the mentioned issues.
committed on rev. 43330

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/nodes/...
File source/blender/compositor/nodes/COM_ColorMatteNode.cpp (right):

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/nodes/...
source/blender/compositor/nodes/COM_ColorMatteNode.cpp:45:
inputSocketKey->relinkConnections(operationRGBToHSV_Key->getInputSocket(0),
true, 0, graph);
ahh now I understand this. this is the editorNodeInputSocketIndex. changed.

On 2012/01/12 14:16:37, jbkkavt wrote:
> inputSocketKey->relinkConnections(operationRGBToHSV_Key->getInputSocket(0),
> true, 1, graph);
> 
> Should be '1' not '0'

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/operat...
File source/blender/compositor/operations/COM_ColorMatteOperation.cpp (right):

http://codereview.appspot.com/5530079/diff/1/source/blender/compositor/operat...
source/blender/compositor/operations/COM_ColorMatteOperation.cpp:54: float
alpha;
copy+paste legacy. removed
On 2012/01/12 14:16:37, jbkkavt wrote:
> Can't see where this is used

Expand All Messages | Collapse All Messages