Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 5530062: code review 5530062: image: rename image.Tiled to image.Repeated. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by nigeltao
Modified:
12 years, 4 months ago
Reviewers:
CC:
r, rsc, golang-dev
Visibility:
Public.

Description

image: rename image.Tiled to image.Repeated. What package image currently provides is a larger image consisting of many copies of a smaller image. More generally, a tiled image could be a quilt consisting of different smaller images (like Google Maps), or a technique to view a portion of enormous images without requiring the whole thing in memory. This richer construct might not ever belong in the standard library (and is definitely out of scope for Go 1), but I would like the option for image.Tiled to be its name.

Patch Set 1 #

Patch Set 2 : diff -r 876070cba27d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 876070cba27d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 876070cba27d https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 876070cba27d https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r e1ed4e6723eb https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -11 lines) Patch
M src/cmd/gofix/Makefile View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/cmd/gofix/imagetiled.go View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A src/cmd/gofix/imagetiled_test.go View 1 2 3 1 chunk +41 lines, -0 lines 0 comments Download
M src/pkg/image/names.go View 1 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 4 months ago (2012-01-10 05:27:33 UTC) #1
r
LGTM i guess.
12 years, 4 months ago (2012-01-10 07:00:54 UTC) #2
nigeltao
12 years, 4 months ago (2012-01-11 01:35:14 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=817e84598240 ***

image: rename image.Tiled to image.Repeated.

What package image currently provides is a larger image consisting
of many copies of a smaller image.

More generally, a tiled image could be a quilt consisting of different
smaller images (like Google Maps), or a technique to view a portion of
enormous images without requiring the whole thing in memory.

This richer construct might not ever belong in the standard library (and
is definitely out of scope for Go 1), but I would like the option for
image.Tiled to be its name.

R=r, rsc
CC=golang-dev
http://codereview.appspot.com/5530062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b