Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(478)

Issue 5530050: code review 5530050: libmach: cross compiling support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by minux1
Modified:
13 years, 5 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

libmach: cross compiling support We already use GOHOSTOS to represent the host OS that the toolchain will be run on, so no need to resort to uname(1) to get that (and use uname(1) will make cross-compiling for another host impossible).

Patch Set 1 #

Patch Set 2 : diff -r 10cf6abf57ca https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/libmach/Makefile View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4
minux1
Hello rsc@golang.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 6 months ago (2012-01-09 08:43:09 UTC) #1
minux1
Gentle ping. IMHO, this CL make the libmach/Makefile's intent more clear and the handling of ...
13 years, 6 months ago (2012-01-20 12:12:10 UTC) #2
rsc
LGTM
13 years, 6 months ago (2012-01-20 18:30:28 UTC) #3
rsc
13 years, 6 months ago (2012-01-20 18:34:32 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=8fc7d691465c ***

libmach: cross compiling support
        We already use GOHOSTOS to represent the host OS that the toolchain
        will be run on, so no need to resort to uname(1) to get that (and
        use uname(1) will make cross-compiling for another host impossible).

R=rsc, golang-dev
CC=golang-dev
http://codereview.appspot.com/5530050

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b