Issue 5529073: code review 5529073: html/template: reenable testcases and fix mis-escaped s...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5529073: code review 5529073: html/template: reenable testcases and fix mis-escaped s... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by MikeSamuel

Modified:
13 years, 6 months ago

Reviewers:

CC:
golang-dev, rsc, nigeltao

Visibility:
Public.

Description

html/template: reenable testcases and fix mis-escaped sequences. Tighter octal parsing broke some tests and were disabled in http://codereview.appspot.com/5530051 Those tests were broken. The CSS decoder was supposed to see CSS hex escape sequences of the form '\' <hex>+, but those escape sequences were instead being consumed by the template parser. This change properly escapes those escape sequences, and uses proper escaping for NULs.

Patch Set 1 #

Patch Set 2 : diff -r e287fecf68dc https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r e287fecf68dc https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 75f7ab3d2d9e https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
	M	src/pkg/html/template/escape_test.go	View	1	1 chunk	+10 lines, -12 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

MikeSamuel

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2012-01-11 22:25:42 UTC) #1

MikeSamuel

13 years, 6 months ago (2012-01-11 23:47:11 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=38f6d55c2cf8 ***

html/template: reenable testcases and fix mis-escaped sequences.

Tighter octal parsing broke some tests and were disabled in
http://codereview.appspot.com/5530051

Those tests were broken.  The CSS decoder was supposed to see CSS
hex escape sequences of the form '\' <hex>+, but those escape
sequences were instead being consumed by the template parser.

This change properly escapes those escape sequences, and uses
proper escaping for NULs.

R=golang-dev, rsc, nigeltao
CC=golang-dev
http://codereview.appspot.com/5529073

Expand All Messages | Collapse All Messages