code review 5528109: html/template: fix docs after API changes

html/template: fix docs after API changes

[niemeyer, 2012-01-17 02:38:50]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2012-01-17 05:25:09]

http://codereview.appspot.com/5528109/diff/4/src/pkg/html/template/doc.go
File src/pkg/html/template/doc.go (right):

http://codereview.appspot.com/5528109/diff/4/src/pkg/html/template/doc.go#new...
src/pkg/html/template/doc.go:34: t, err := template.New("").Parse(`{{define
"T"}}Hello, {{.}}!{{end}}`)
s/""/"foo"/
might as well get people used to providing names.

http://codereview.appspot.com/5528109/diff/4/src/pkg/html/template/doc.go#new...
src/pkg/html/template/doc.go:45: t, err := template.New("").Parse(`{{define
"T"}}Hello, {{.}}!{{end}}`)
ditto

http://codereview.appspot.com/5528109/diff/4/src/pkg/os/exec/lp_unix.go
File src/pkg/os/exec/lp_unix.go (right):

http://codereview.appspot.com/5528109/diff/4/src/pkg/os/exec/lp_unix.go#newco...
src/pkg/os/exec/lp_unix.go:50: path := dir + "/" + file
unrelated change. wrong CL

[niemeyer, 2012-01-17 13:02:33]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[niemeyer, 2012-01-17 13:02:44]

http://codereview.appspot.com/5528109/diff/4/src/pkg/html/template/doc.go
File src/pkg/html/template/doc.go (right):

http://codereview.appspot.com/5528109/diff/4/src/pkg/html/template/doc.go#new...
src/pkg/html/template/doc.go:34: t, err := template.New("").Parse(`{{define
"T"}}Hello, {{.}}!{{end}}`)
On 2012/01/17 05:25:09, r wrote:
> s/""/"foo"/
> might as well get people used to providing names.

Done.

http://codereview.appspot.com/5528109/diff/4/src/pkg/html/template/doc.go#new...
src/pkg/html/template/doc.go:45: t, err := template.New("").Parse(`{{define
"T"}}Hello, {{.}}!{{end}}`)
On 2012/01/17 05:25:09, r wrote:
> ditto

Done.

http://codereview.appspot.com/5528109/diff/4/src/pkg/os/exec/lp_unix.go
File src/pkg/os/exec/lp_unix.go (right):

http://codereview.appspot.com/5528109/diff/4/src/pkg/os/exec/lp_unix.go#newco...
src/pkg/os/exec/lp_unix.go:50: path := dir + "/" + file
On 2012/01/17 05:25:09, r wrote:
> unrelated change. wrong CL

Sorry, I assumed this was this too trivial to deserve its own CL. Will push
separately.

[niemeyer, 2012-01-19 22:19:39]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-01-19 23:35:42]

http://codereview.appspot.com/5528109/diff/9001/src/pkg/os/exec/lp_unix.go
File src/pkg/os/exec/lp_unix.go (right):

http://codereview.appspot.com/5528109/diff/9001/src/pkg/os/exec/lp_unix.go#ne...
src/pkg/os/exec/lp_unix.go:50: if err := findExecutable(dir + "/" + file); err
== nil {
different issue?

[niemeyer, 2012-01-19 23:43:52]

Hello golang-dev@googlegroups.com, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-01-19 23:45:33]

LGTM

[niemeyer, 2012-01-19 23:49:36]

*** Submitted as http://code.google.com/p/go/source/detail?r=8654c453394e ***

html/template: fix docs after API changes

R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5528109