code review 5528089: cmd/go: use relative paths in go fix, go fmt, go vet output

cmd/go: use relative paths in go fix, go fmt, go vet output

Fixes issue 2686.

[rsc, 2012-01-12 22:38:07]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2012-01-12 22:41:10]

LGTM

On Thu, Jan 12, 2012 at 2:38 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> cmd/go: use relative paths in go fix, go fmt, go vet output
>
> Fixes issue 2686.
>
> Please review this at
http://codereview.appspot.com/**5528089/<http://codereview.appspot.com/5528089/>
>
> Affected files:
>  M src/cmd/go/fix.go
>  M src/cmd/go/fmt.go
>  M src/cmd/go/vet.go
>
>
> Index: src/cmd/go/fix.go
> ==============================**==============================**=======
> --- a/src/cmd/go/fix.go
> +++ b/src/cmd/go/fix.go
> @@ -25,6 +25,7 @@
>                // Use pkg.gofiles instead of pkg.Dir so that
>                // the command only applies to this package,
>                // not to packages in subdirectories.
> -               run(stringList("gofix", pkg.gofiles))
> +               out := runOut(stringList("gofix", pkg.gofiles))
> +               os.Stdout.WriteString(**relPaths(pkg.Dir, string(out)))
>        }
>  }
> Index: src/cmd/go/fmt.go
> ==============================**==============================**=======
> --- a/src/cmd/go/fmt.go
> +++ b/src/cmd/go/fmt.go
> @@ -4,6 +4,8 @@
>
>  package main
>
> +import "os"
> +
>  var cmdFmt = &Command{
>        Run:       runFmt,
>        UsageLine: "fmt [importpath...]",
> @@ -26,7 +28,8 @@
>                // Use pkg.gofiles instead of pkg.Dir so that
>                // the command only applies to this package,
>                // not to packages in subdirectories.
> -               run(stringList("gofmt", "-I", "w", pkg.gofiles))
> +               out := runOut(stringList("gofmt", "-l", "-w", pkg.gofiles))
> +               os.Stdout.WriteString(**relPaths(pkg.Dir, string(out)))
>        }
>  }
>
> Index: src/cmd/go/vet.go
> ==============================**==============================**=======
> --- a/src/cmd/go/vet.go
> +++ b/src/cmd/go/vet.go
> @@ -25,6 +25,7 @@
>                // Use pkg.gofiles instead of pkg.Dir so that
>                // the command only applies to this package,
>                // not to packages in subdirectories.
> -               run("govet", pkg.gofiles)
> +               out := runOut(stringList("govet", pkg.gofiles))
> +               os.Stdout.WriteString(**relPaths(pkg.Dir, string(out)))
>        }
>  }
>
>
>

[rsc, 2012-01-12 23:12:42]

Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[r, 2012-01-12 23:14:24]

LGTM

http://codereview.appspot.com/5528089/diff/2006/src/cmd/go/build.go
File src/cmd/go/build.go (right):

http://codereview.appspot.com/5528089/diff/2006/src/cmd/go/build.go#newcode812
src/cmd/go/build.go:812: // made relative to the current directory if that would
be shorter.
number problem in the grammar.
maybe s/that/they/

[rsc, 2012-01-12 23:28:53]

*** Submitted as 162c7fe57d78 ***

cmd/go: use relative paths in go fix, go fmt, go vet output

Fixes issue 2686.

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/5528089