Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 5528054: [google/main] Fix erroneous output of pubnames when no .debug_section is emitted.

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by saugustine
Modified:
13 years, 3 months ago
Reviewers:
Cary
CC:
gcc-patches_gcc.gnu.org
Visibility:
Public.

Description

Certain source files will not produce a .debug_info section. This patch to google/main adds a check for that case to output_pubnames, preventing a link failure. Tested: By rebuild and bootstrap. ChangeLog: 2012-01-09 Sterling Augustine <saugustine@google.com> * gcc/dwarf2out.c (output_pubnames): Add check for info_section_emitted.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gcc/dwarf2out.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
saugustine
Certain source files will not produce a .debug_info section. This patch to google/main adds a ...
13 years, 3 months ago (2012-01-09 22:18:50 UTC) #1
Cary
13 years, 3 months ago (2012-01-09 23:09:44 UTC) #2
> Certain source files will not produce a .debug_info section. This patch to
> google/main adds a check for that case to output_pubnames, preventing a link
> failure.
>
> Tested:
>        By rebuild and bootstrap.
>
> ChangeLog:
>
> 2012-01-09   Sterling Augustine  <saugustine@google.com>
>
>        * gcc/dwarf2out.c (output_pubnames): Add check for
info_section_emitted.

LGTM.

-cary
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b