Issue 5527064: code review 5527064: html: propagate foreign namespaces only when adding for...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5527064: code review 5527064: html: propagate foreign namespaces only when adding for... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by nigeltao

Modified:
13 years, 6 months ago

Reviewers:

CC:
andybalholm, golang-dev

Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : diff -r 876070cba27d https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 876070cba27d https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 042b4923b689 https://go.googlecode.com/hg/ #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	src/pkg/html/parse.go	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
	M	src/pkg/html/parse_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello andybalholm@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 6 months ago (2012-01-10 02:53:29 UTC) #1

nigeltao

13 years, 6 months ago (2012-01-10 23:15:54 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=5bdb5a13fbc0 ***

html: propagate foreign namespaces only when adding foreign content.

Pass tests10.dat, test 31:
<div><svg><path><foreignObject><p></div>a

| <html>
|   <head>
|   <body>
|     <div>
|       <svg svg>
|         <svg path>
|           <svg foreignObject>
|             <p>
|               "a"

Also pass test 32:
<!DOCTYPE html><svg><desc><div><svg><ul>a

R=andybalholm
CC=golang-dev
http://codereview.appspot.com/5527064

Expand All Messages | Collapse All Messages