Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(324)

Issue 5523049: code review 5523049: time: fix godoc for After and NewTicker. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Sameer Ajmani
Modified:
13 years, 4 months ago
Reviewers:
CC:
golang-dev, gri, bradfitz, iant, rsc
Visibility:
Public.

Description

time: fix godoc for After and NewTicker.

Patch Set 1 #

Patch Set 2 : diff -r ede0548adf59 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r ede0548adf59 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ede0548adf59 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 52ae6fbcc97a https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/pkg/time/sleep.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/pkg/time/tick.go View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Sameer Ajmani
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com, rsc@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
13 years, 4 months ago (2012-01-06 19:12:33 UTC) #1
gri
LGTM FYI: rsc and r believe in 2 blanks after a period.
13 years, 4 months ago (2012-01-06 21:19:17 UTC) #2
bradfitz
I believe the last spaces-after-periods discussion ended in 1) whatever, 2) local consistency, mostly, 3) ...
13 years, 4 months ago (2012-01-06 21:43:38 UTC) #3
Sameer Ajmani
I removed the whitespace changes. They were automatically inserted by my nigelize emacs hook. On ...
13 years, 4 months ago (2012-01-06 21:51:37 UTC) #4
iant
LGTM
13 years, 4 months ago (2012-01-06 22:27:23 UTC) #5
Sameer Ajmani
13 years, 4 months ago (2012-01-08 01:54:35 UTC) #6
*** Submitted as http://code.google.com/p/go/source/detail?r=9527ad01273b ***

time: fix godoc for After and NewTicker.

R=golang-dev, gri, bradfitz, iant
CC=golang-dev, rsc
http://codereview.appspot.com/5523049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b