Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14548)

Issue 5507050: Doc: Learning: Use voices in the intended order. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by Keith
Modified:
12 years, 1 month ago
Reviewers:
Graham Percival, carl.d.sorensen, Trevor Daniels, t.daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: Learning: Use voices in the intended order. Doc: Notation: Mention how hideNotes hides beams.

Patch Set 1 #

Patch Set 2 : grammar #

Patch Set 3 : indentation #

Total comments: 1

Patch Set 4 : update if hideNotes hides Rests #

Patch Set 5 : fix fatal error #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -49 lines) Patch
M Documentation/learning/fundamental.itely View 1 2 3 4 5 chunks +31 lines, -27 lines 2 comments Download
M Documentation/learning/tweaks.itely View 1 2 3 4 2 chunks +23 lines, -18 lines 0 comments Download
M Documentation/notation/editorial.itely View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7
Carl
LGTM
12 years, 3 months ago (2012-01-02 16:37:47 UTC) #1
Graham Percival
this commit appears to break staging. http://codereview.appspot.com/5507050/diff/6001/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): http://codereview.appspot.com/5507050/diff/6001/Documentation/learning/tweaks.itely#newcode2899 Documentation/learning/tweaks.itely:2899: \\ are you ...
12 years, 3 months ago (2012-01-07 02:41:11 UTC) #2
Graham Percival
On 2012/01/07 02:41:11, Graham Percival wrote: > this commit appears to break staging. hmm, I'm ...
12 years, 3 months ago (2012-01-07 03:20:55 UTC) #3
Trevor Daniels
I could see no reason for this patch causing problems with make or make doc ...
12 years, 1 month ago (2012-03-10 12:36:05 UTC) #4
Trevor Daniels
The second part of this patch has now been pushed to staging, so (assuming they ...
12 years, 1 month ago (2012-03-10 15:17:04 UTC) #5
Keith
On 2012/03/10 12:36:05, Trevor Daniels wrote: > I could see no reason for this patch ...
12 years, 1 month ago (2012-03-13 05:53:39 UTC) #6
t.daniels_treda.co.uk
12 years, 1 month ago (2012-03-13 09:41:36 UTC) #7
Keith, you wrote Tuesday, March 13, 2012 5:53 AM
Subject: Re: Doc: Learning: Use voices in the intended order. (issue 
5507050)


> On 2012/03/10 12:36:05, Trevor Daniels wrote:
>> I could see no reason for this patch causing problems
>
> I had mis-spelled the option to ignore-collisions, which threw a
> warning, but I didn't catch it because other overrides made the
> ignore-collisions setting (which you removed) redundant, so the output
> looked fine.
>
> Thanks for running a make-doc and pushing.

You're welcome - as the original misleading voice ordering was mine I was 
happy to get it fixed!

Trevor

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b