Issue 5505071: Clear screen before displaying window

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5505071: Clear screen before displaying window (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by nicholasbishop

Modified:
12 years, 2 months ago

Reviewers:
brechtvl, bf-codereview

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Description

On my system (Ubuntu 11.10, ATI Mobility Radeon HD 5650, Gallium drivers) the default GL display seems to be using uninitialized memory. During Blender startup, when the window is first displayed there is a brief flash of random data. This patch fixes by adding a glClear() inbetween creating the GLX context and displaying the window. I also call glClearColor with a hardcoded grey from the default theme.

Patch Set 1 #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
		intern/ghost/intern/GHOST_WindowX11.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nicholasbishop

12 years, 4 months ago (2011-12-26 19:12:47 UTC) #3

On 2011/12/26 13:31:41, brechtvl wrote:
> LGTM

Thanks, committed.

Expand All Messages | Collapse All Messages