Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(254)

Issue 5505066: code review 5505066: snappy: import path gofixes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by nigeltao
Modified:
12 years, 5 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

snappy: import path gofixes.

Patch Set 1 #

Patch Set 2 : diff -r eda18139736a https://code.google.com/p/snappy-go/ #

Patch Set 3 : diff -r eda18139736a https://code.google.com/p/snappy-go/ #

Patch Set 4 : diff -r eda18139736a https://code.google.com/p/snappy-go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M snappy/Makefile View 1 1 chunk +1 line, -1 line 0 comments Download
M snappy/snappy_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
nigeltao
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/snappy-go/
12 years, 5 months ago (2011-12-22 23:20:58 UTC) #1
bradfitz
LGTM On Thu, Dec 22, 2011 at 3:20 PM, <nigeltao@golang.org> wrote: > Reviewers: bradfitz, > ...
12 years, 5 months ago (2011-12-22 23:24:57 UTC) #2
bradfitz
Or you could even just kill the Makefile now, right? On Thu, Dec 22, 2011 ...
12 years, 5 months ago (2011-12-22 23:25:17 UTC) #3
nigeltao
*** Submitted as 735865deca6a *** snappy: import path gofixes. R=bradfitz CC=golang-dev http://codereview.appspot.com/5505066
12 years, 5 months ago (2011-12-22 23:39:39 UTC) #4
nigeltao
12 years, 5 months ago (2011-12-22 23:54:21 UTC) #5
On 23 December 2011 10:25, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> Or you could even just kill the Makefile now, right?

I'll kill the Makefiles in snappy-go once they're gone from the
standard package library.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b