Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 5505061: code review 5505061: testing: make signalling safer for parallel tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by r
Modified:
13 years, 7 months ago
Reviewers:
CC:
r, r2, golang-dev
Visibility:
Public.

Description

testing: make signalling safer for parallel tests Each test gets a private signal channel. Also fix a bug that prevented parallel tests from running.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 5ebba0f3d053 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M src/pkg/testing/testing.go View 1 5 chunks +13 lines, -7 lines 0 comments Download

Messages

Total messages: 5
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
13 years, 7 months ago (2011-12-21 23:52:36 UTC) #1
r2
This is for Russ. There was some problem in prior testing that was made harder ...
13 years, 7 months ago (2011-12-22 00:02:53 UTC) #2
rsc
LGTM If you want to add a comment, the bug this avoids is that it ...
13 years, 7 months ago (2011-12-22 18:34:17 UTC) #3
r2
On Dec 22, 2011, at 10:34 AM, rsc@golang.org wrote: > LGTM > > If you ...
13 years, 7 months ago (2011-12-22 18:37:32 UTC) #4
r
13 years, 7 months ago (2011-12-22 18:44:08 UTC) #5
*** Submitted as 8206c6c7ebd4 ***

testing: make signalling safer for parallel tests
Each test gets a private signal channel.
Also fix a bug that prevented parallel tests from running.

R=r, r
CC=golang-dev
http://codereview.appspot.com/5505061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b